Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong NaN check in MovingFunctions#stdDev() #31888

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Fix wrong NaN check in MovingFunctions#stdDev() #31888

merged 1 commit into from
Jul 10, 2018

Commits on Jul 9, 2018

  1. Fix broken NaN check in MovingFunctions#stdDev() 

    The initial check will never be true, because of the special semantics of NaN,
where no value is equal to Nan, including NaN. Thus, x == Double.NaN always
evaluates to false. The method still works correct because later computations
will also return NaN if the avg argument is NaN, but the intended shortcut
doesn't work.
    Christoph Büscher committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    dc89947 View commit details
    Browse the repository at this point in the history