Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertIngestDocument wrongfully passing #31913

Merged
merged 3 commits into from
Jul 11, 2018
Merged

Fix assertIngestDocument wrongfully passing #31913

merged 3 commits into from
Jul 11, 2018

Commits on Jul 10, 2018

  1. Fix assertIngestDocument wrongfully passing 

    * Previously docA being subset of docB passed because iteration was over docA's keys only
* Scalars in nested fields were not compared in all cases
* Assertion errors were hard to interpret (message wasn't correct since it only mentioned the class type)
* In cases where two paths contained different types a ClassCastException was thrown instead of an AssertionError
* Fixes elastic#28492
    @original-brownbear
    original-brownbear committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    bcd739d View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. Merge remote-tracking branch 'elastic/master' into 28492

    @original-brownbear
    original-brownbear committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    621f448 View commit details
    Browse the repository at this point in the history

  2. rename test methods

    @original-brownbear
    original-brownbear committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    096b081 View commit details
    Browse the repository at this point in the history