Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve message when JAVA_HOME not set #32022

Merged
merged 1 commit into from
Jul 21, 2018
Merged

Improve message when JAVA_HOME not set #32022

merged 1 commit into from
Jul 21, 2018

Conversation

alpar-t
Copy link
Contributor

@alpar-t alpar-t commented Jul 13, 2018

Offer a hint about the Gradle daemon and link to issue for details.

closes #31399

@alpar-t alpar-t added the :Delivery/Build Build or test infrastructure label Jul 13, 2018
@alpar-t alpar-t requested a review from rjernst July 13, 2018 05:47
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@alpar-t
Copy link
Contributor Author

alpar-t commented Jul 19, 2018

@rjernst @nik9000 can one of you take a look please ?

nik9000
nik9000 approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me.

rjernst
rjernst approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@alpar-t alpar-t merged commit 0a511cc into elastic:master Jul 21, 2018
alpar-t added a commit that referenced this pull request Jul 21, 2018
@alpar-t
Improve message when JAVA_HOME not set (#32022)
9f55f03 
closes #31399
dnhatn added a commit that referenced this pull request Jul 22, 2018
@dnhatn
Merge branch '6.x' into ccr-6.x
566f9b4 
* 6.x:
  Improve message when JAVA_HOME not set (#32022)
  INGEST: Make a few Processors callable by Painless (#32170) (#32261)
  INGEST: Extend KV Processor (#31789) (#32232) (#32262)
dnhatn added a commit that referenced this pull request Jul 22, 2018
@dnhatn
Merge branch 'master' into ccr
0cd25d7 
* master:
  Improve message when JAVA_HOME not set (#32022)
  [TEST] improve REST high-level client naming conventions check (#32244)
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjernst rjernst rjernst approved these changes

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v6.4.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gradle idea incorrectly fails with JAVA_HOME not set
6 participants
@alpar-t @elasticmachine @nik9000 @rjernst @colings86 @mark-vieira