Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put LIMIT 10 to the SQL query #32065

Merged
merged 1 commit into from
Jul 16, 2018
Merged

put LIMIT 10 to the SQL query #32065

merged 1 commit into from
Jul 16, 2018

Conversation

ahmedakef
Copy link
Contributor

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@colings86 colings86 added the :Analytics/SQL SQL querying label Jul 16, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@colings86 colings86 added the >docs General docs changes label Jul 16, 2018
@imotov
Copy link
Contributor

imotov commented Jul 16, 2018

@elasticmachine test this please

@imotov
Copy link
Contributor

imotov commented Jul 16, 2018

@elasticmachine run sample packaging tests

@imotov imotov added the :Analytics/Aggregations Aggregations label Jul 16, 2018
@imotov imotov changed the base branch from 6.3 to master July 16, 2018 19:51
@imotov imotov changed the base branch from master to 6.3 July 16, 2018 19:51
imotov
imotov approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmedakef in the future, could you please open PRs against master instead of other branches (in this case 6.3) and provide a better commit description.

@imotov imotov merged commit b3ad0a4 into elastic:6.3 Jul 16, 2018
imotov pushed a commit that referenced this pull request Jul 16, 2018
@ahmedakef @imotov
DOCS: put LIMIT 10 to the SQL query (#32065)
d0a0e19 
Provides a more precise equivalent SQL query for the aggregation example in the getting started guide.
imotov pushed a commit that referenced this pull request Jul 16, 2018
@ahmedakef @imotov
DOCS: put LIMIT 10 to the SQL query (#32065)
5b65e2c 
Provides a more precise equivalent SQL query for the aggregation example in the getting started guide.
martijnvg added a commit that referenced this pull request Jul 17, 2018
@martijnvg
Merge remote-tracking branch 'es/6.x' into ccr-6.x
38f8cdb 
* es/6.x:
  Scripting: Remove dead code from painless module (#32064) (#32104)
  Painless: Move and Rename Several Methods in the lookup package (#32105)
  Bypass highlight query terms extraction on empty fields (#32090)
  Core: Backport java time date formatters (#31997)
  Switch non-x-pack to new style requests (#32106)
  SQL: allow LEFT and RIGHT as function names (#32066)
  Painless: Separate PainlessLookup into PainlessLookup and PainlessLookupBuilder (#32054)
  [test] turn on host io cache for opensuse (#32053)
  DOCS: put LIMIT 10 to the SQL query (#32065)
martijnvg added a commit that referenced this pull request Jul 17, 2018
@martijnvg
Merge remote-tracking branch 'es/master' into ccr
d0c9cf2 
* es/master:
  Add Index UUID to `/_stats` Response (#31871)
  Painless: Move and Rename Several Methods in the lookup package (#32105)
  Bypass highlight query terms extraction on empty fields (#32090)
  Switch non-x-pack to new style requests (#32106)
  [Rollup] Add new capabilities endpoint for concrete rollup indices (#30401)
  Revert "[test] disable packaging tests for suse boxes"
  SQL: allow LEFT and RIGHT as function names (#32066)
  DOCS: put LIMIT 10 to the SQL query (#32065)
  [test] turn on host io cache for opensuse (#32053)
  Tweaked Elasticsearch Service links for SEO
@ahmedakef
Copy link
Contributor Author

@imotov Thanks, I will consider that in the future ISA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imotov imotov imotov approved these changes

Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations >docs General docs changes v6.3.2 v6.4.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmedakef @elasticmachine @imotov @colings86