Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest HL client: Add put watch action (#32026) #32191

Merged

Conversation

spinscale
Copy link
Contributor

Relates #29827

This implementation behaves like the current transport client, that you basically cannot configure a Watch POJO representation as an argument to the put watch API, but only a bytes reference. You can use the the WatchSourceBuilder from the org.elasticsearch.plugin:x-pack-core dependency to build watches.

This commit also changes the license type to trial, so that watcher is available in high level rest client tests.

Relates elastic#29827

This implementation behaves like the current transport client, that you basically cannot configure a Watch POJO representation as an argument to the put watch API, but only a bytes reference. You can use the the `WatchSourceBuilder` from the `org.elasticsearch.plugin:x-pack-core` dependency to build watches.

This commit also changes the license type to trial, so that watcher is available in high level rest client tests.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@droberts195
Copy link
Contributor

You can use the the WatchSourceBuilder from the org.elasticsearch.plugin:x-pack-core dependency to build watches.

Would most people who used Watcher via the transport client have used WatchSourceBuilder? If they would have, then it seems to me that excluding it from the high level REST client means the high level REST client is not really a drop-in replacement for the transport client. If the solution to this problem is to recommend that people make their client applications depend on the x-pack-core library as well as the high level REST client then it makes me wonder why we're bothering to create an X-Pack protocol library, because x-pack-core is just adding back the dependencies that have supposedly been avoided. It seems to me like there are conflicting requirements of (a) wanting the high level REST client to be a drop-in replacement for the transport client and (b) wanting to minimise dependencies.

(The discussion in #32167 is also relevant to this same high level trade-off.)

@hub-cap
Copy link
Contributor

hub-cap commented Jul 19, 2018

while i think its hard to know what the users use, I think that it might be possible, given the comments in #32167 to create client side objects and use the builders. We should definitely come to a consensus on this, and remember, even tho this is going to be usable in 7.0, the transport client wont be removed until 8.0, and that gives us a lot of time to further build out the client side objects discussed between this PR and #32167.

@spinscale
Copy link
Contributor Author

waiting for backport of #31825 to push this

@spinscale spinscale merged commit def9509 into elastic:6.x Jul 24, 2018
dnhatn added a commit that referenced this pull request Jul 25, 2018
* 6.x:
  Security: revert to old way of merging automata (#32254)
  Fix a test bug in RangeQueryBuilderTests introduced in the field aliases backport.
  Introduce Application Privileges with support for Kibana RBAC (#32309)
  Undo a debugging change that snuck in during the field aliases merge.
  [test] port linux package packaging tests (#31943)
  Painless: Update More Methods to New Naming Scheme (#32305)
  Tribe: Add error with secure settings copied to tribe (#32298)
  Add V_6_3_3 version constant
  Add ERR to ranking evaluation documentation (#32314)
  [DOCS] Added link to 6.3.2 RNs
  [DOCS] Updates 6.3.2 release notes with PRs from ml-cpp repo (#32334)
  [Kerberos] Add Kerberos authentication support (#32263)
  [ML] Extract persistent task methods from MlMetadata (#32319)
  Backport - Add Snapshots Status API to High Level Rest Client (#32295)
  Make release notes ignore the `>test-failure` label. (#31309)
  [DOCS] Adds release highlights for search for 6.4 (#32095)
  Allow Integ Tests to run in a FIPS-140 JVM (#32316)
  Add support for field aliases to 6.x. (#32184)
  Register ERR metric with NamedXContentRegistry (#32320)
  fixes broken build for third-party-tests (#32315) Relates #31918 / Closes infra/issues/6085
  [DOCS] Rollup Caps API incorrectly mentions GET Jobs API (#32280)
  Rest HL client: Add put watch action (#32026) (#32191)
  Add WeightedAvg metric aggregation (#31037)
  Consistent encoder names (#29492)
  Switch monitoring to new style Requests (#32255)
  specify subdirs of lib, bin, modules in package (#32253)
  Rename ranking evaluation `quality_level` to `metric_score` (#32168)
  Add new permission for JDK11 to load JAAS libraries (#32132)
  Switch x-pack:core to new style Requests (#32252)
  Watcher: Store username on watch execution (#31873)
  Silence SSL reload test that fails on JDK 11
  Painless: Clean up add methods in PainlessLookup (#32258)
  CCE when re-throwing "shard not available" exception in TransportShardMultiGetAction (#32185)
  Fail shard if IndexShard#storeStats runs into an IOException (#32241)
  Fix `range` queries on `_type` field for singe type indices (#31756) (#32161)
  AwaitsFix RecoveryIT#testHistoryUUIDIsGenerated
  Add new fields to monitoring template for Beats state (#32085) (#32273)
  [TEST] improve REST high-level client naming conventions check (#32244)
  Check that client methods match API defined in the REST spec (#31825)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants