Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi level nested sort #32204

Merged
merged 5 commits into from
Jul 20, 2018
Merged

Fix multi level nested sort #32204

merged 5 commits into from
Jul 20, 2018

Commits on Jul 19, 2018

  1. Fix sort values coming from unrelated documents in certain multi-leve… 

    …l sorts elastic#31554
    @dbevacqua @jimczi
    dbevacqua authored and jimczi committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    edac443 View commit details
    Browse the repository at this point in the history

  2. added a better unit test

    @martijnvg @jimczi
    martijnvg authored and jimczi committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    cd69c52 View commit details
    Browse the repository at this point in the history

  3. Simplify parent filter for nested sort 

    The parent filter for nested sort should always match **all** parents regardless
of the child queries. It is used to find the boundaries of a single parent and we use
the child query to match all the filters set in the nested tree so there is no need to
repeat the nested filters.
With this change we ensure that we build bitset filters
only to find the root docs (or the docs at the level where the sort applies) that can be reused
among queries.

Closes elastic#31783
    @jimczi
    jimczi committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    8ecc35b View commit details
    Browse the repository at this point in the history

  4. fix checkstyle

    @jimczi
    jimczi committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    51e02b8 View commit details
    Browse the repository at this point in the history

  5. fix non nested mode

    @jimczi
    jimczi committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    dba38db View commit details
    Browse the repository at this point in the history