Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kerberos] Replace deprecated char ':' from build.gradle #32247

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

bizybot
Copy link
Contributor

@bizybot bizybot commented Jul 20, 2018

From Gradle 5.0 onwards use of few characters will not be allowed in tasks,
one of the chars is ':'. This commit replaces that character. Also, add a dependency
for copy task on the creation of principal names.

From 5.0 onwards use of few characters will not be allowed, one
of them is ':'. This commit removes that character. Also add
dependency for copy task on creation of principal names which
caused problems with clean test runs.
@bizybot bizybot added >feature review :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) labels Jul 20, 2018
@bizybot bizybot requested a review from jaymode July 20, 2018 15:33
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bizybot bizybot merged commit 158f585 into elastic:feature/kerberos Jul 20, 2018
@bizybot bizybot deleted the kerberos/refactoring3 branch July 20, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>feature :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants