Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTS: Fix Buf Leaks in HttpReadWriteHandlerTests #32377

Merged
merged 2 commits into from
Jul 26, 2018
Merged

TESTS: Fix Buf Leaks in HttpReadWriteHandlerTests #32377

merged 2 commits into from
Jul 26, 2018

Commits on Jul 25, 2018

  1. TESTS: Fix Buf Leaks in HttpReadWriteHandlerTests 

    * Release all ref counted things that weren't getting properly released
* Mannually force channel promise to be completed because mock channel doesn't do it and it prevents one `release` call in `io.netty.channel.ChannelOutboundHandlerAdapter#write` from firing
* Now passes a few thousand iterations with leak detection set to paranoid
    @original-brownbear
    original-brownbear committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    00294c1 View commit details
    Browse the repository at this point in the history

  2. CR: Revert noop release call

    @original-brownbear
    original-brownbear committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    8ecc45c View commit details
    Browse the repository at this point in the history