Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename authorizing_realms to authorization_realms #32391

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Rename authorizing_realms to authorization_realms #32391

merged 1 commit into from
Jul 31, 2018

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Jul 26, 2018

The previous name incorrectly implies that the realms are actively
authorizing something, however the reality is that they are realms
that are consulted for the purposes of authorization.

@tvernum
Rename authorizing_realms to authorization_realms
81e8770 
The previous name incorrectly implies that the realms are actively
authorizing something, however the reality is that they are realms
that are consulted for the purposes of authorization.
@tvernum tvernum added review :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC labels Jul 26, 2018
@tvernum tvernum requested review from bizybot and jaymode July 26, 2018 08:01
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

bizybot
bizybot approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@bizybot bizybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

jaymode
jaymode approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvernum tvernum merged commit d9e5bb9 into elastic:security-lookup-realms Jul 31, 2018
@tvernum tvernum removed the review label Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymode jaymode jaymode approved these changes

@bizybot bizybot bizybot approved these changes

Assignees
No one assigned
Labels
:Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tvernum @elasticmachine @bizybot @jaymode