Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network-host.asciidoc #32429

Merged
merged 2 commits into from
Aug 16, 2018
Merged

Update network-host.asciidoc #32429

merged 2 commits into from
Aug 16, 2018

Conversation

datosh
Copy link
Contributor

@datosh datosh commented Jul 27, 2018

Minor correction. Two words were mixed up in documentation.

Minor correction. Two words were mixed up in documentation.
@datosh
Copy link
Contributor Author

datosh commented Jul 27, 2018

I have just signed the CLA, since this is my first contribution. I have confirmed my mail, and received the document. Everything should be in order :)

@colings86 colings86 added >docs General docs changes :Distributed Coordination/Network Http and internode communication implementations labels Jul 30, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@nik9000
Copy link
Member

nik9000 commented Jul 31, 2018

Soooo I think both word orders are valid here though I think the one in the docs is slightly better. I wonder if we should just remove to communicate and to from the sentence entirely though.

@datosh
Copy link
Contributor Author

datosh commented Aug 2, 2018

Yeah, makes also more sense to me, to remove the whole thing.

@javanna javanna changed the base branch from 6.3 to master August 16, 2018 09:33
@javanna javanna changed the base branch from master to 6.x August 16, 2018 09:33
@javanna javanna changed the base branch from 6.x to 6.3 August 16, 2018 09:34
@javanna javanna merged commit 773d74d into elastic:6.3 Aug 16, 2018
@javanna
Copy link
Member

javanna commented Aug 16, 2018

thanks @datosh !

@javanna javanna added the v6.3.3 label Aug 16, 2018
@datosh datosh deleted the patch-1 branch August 21, 2018 13:35
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Aug 24, 2018
…-checkpoint-poll

* 'master' of github.com:elastic/elasticsearch:
  Fix docs for fixed filename for heap dump path (elastic#32882)
  Painless: Special Case def (elastic#32871)
  AwaitFix FullClusterRestartIT#testRollupIDSchemeAfterRestart.
  [Test] Fix DuelScrollIT#testDuelIndexOrderQueryThenFetch
  HLRC: adding machine learning delete job (elastic#32820)
  [DOCS] Update WordPress plugins links (elastic#32194)
  Remove passphrase support from reload settings API (elastic#32889)
  AwaitFix AckIT.
  Mutes test in DuelScrollIT
  CharArraysTests: Fix test bug.
  [ML] Choose seconds to fix intermittent DatafeeedConfigTest failure
  Test: Fix unpredictive merges in DocumentSubsetReaderTests
  [DOCS] Clarify sentence in network-host.asciidoc (elastic#32429)
  Docs enhancement: added reference to cluster-level setting `search.default_allow_partial_results` (elastic#32810)
  [DOCS] Fixing cross doc link to Stack Overview security topic.
  Move CharArrays to core lib (elastic#32851)
  Fix global checkpoint listeners test
  HLRC: adding machine learning open job (elastic#32860)
  [ML] Add log structure finder functionality (elastic#32788)
  INGEST: Add Configuration Except. Data to Metdata (elastic#32322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Network Http and internode communication implementations >docs General docs changes v6.3.3 v6.4.0 v6.5.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants