[Rollup] Move toAggCap() methods out of rollup config objects #32583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
review
v7.0.0
>refactoring
:StorageEngine/Rollup
|
Pinging @elastic/es-search-aggs |
jimczi
approved these changes
Aug 2, 2018
tlrx
force-pushed
the
move-toaggcap-methods-out-of-rollup-config-objects
branch
from
4368719
to
533d913
Compare
|
@polyfractal I fixed the conflicts, can you have another look please? Thanks |
tlrx
force-pushed
the
move-toaggcap-methods-out-of-rollup-config-objects
branch
from
533d913
to
200ee45
Compare
tlrx
added a commit
that referenced
this pull request
Aug 24, 2018
|
Thanks @jimczi and @polyfractal |
jimczi
pushed a commit
that referenced
this pull request
Aug 24, 2018
dnhatn
added a commit
that referenced
this pull request
Aug 26, 2018
* master: Add proxy support to RemoteClusterConnection (#33062) TEST: Skip assertSeqNos for closed shards (#33130) TEST: resync operation on replica should acquire shard permit (#33103) Switch remaining x-pack tests to new style Requests (#33108) Switch remaining tests to new style Requests (#33109) Switch remaining ml tests to new style Requests (#33107) Build: Line up IDE detection logic Security index expands to a single replica (#33131) HLRC: request/response homogeneity and JavaDoc improvements (#33133) Checkstyle! [Test] Fix sporadic failure in MembershipActionTests Revert "Do NOT allow termvectors on nested fields (#32728)" [Rollup] Move toAggCap() methods out of rollup config objects (#32583) Fix race condition in scheduler engine test
dnhatn
added a commit
that referenced
this pull request
Aug 26, 2018
* 6.x: Allow engine to recover from translog upto a seqno (#33032) TEST: Skip assertSeqNos for closed shards (#33130) TEST: resync operation on replica should acquire shard permit (#33103) Add proxy support to RemoteClusterConnection (#33062) Build: Line up IDE detection logic Security index expands to a single replica (#33131) Suppress more tests HLRC: request/response homogeneity and JavaDoc improvements (#33133) [Rollup] Move toAggCap() methods out of rollup config objects (#32583) Muted all these tests due to #33128 Fix race condition in scheduler engine test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the
toAggCap()methods out of the rollup configuration objects. These methods are used in theRollupJobCapsand can be computed there, simplifying the rollup configuration objects.