Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Painless context doc updates for scripted metric aggregation "state" context variables #32695

Conversation

rationull
Copy link
Contributor

@rationull rationull commented Aug 8, 2018

The changes that this doc refers too were implemented for #29328. The PR that officially deprecates the old functionality is still open (#31597) but the new names are in place on the 6.4 branch.

This change brings the scripted metric agg context docs in line with the new agg state context variable.

…ge from params["_agg"] to 'state' context variable
@rationull rationull changed the title Modify painless context docs for scripted metric aggregation for chan… Painless context doc updates for scripted metric aggregation "state" context variables Aug 8, 2018
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst
Copy link
Member

rjernst commented Aug 9, 2018

@elasticmachine ok to test

@rjernst rjernst added >docs General docs changes :Analytics/Aggregations Aggregations v7.0.0 v6.5.0 labels Aug 9, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@rjernst
Copy link
Member

rjernst commented Aug 9, 2018

@rationull can you sync with master? I think the failure is unrelated

@rationull
Copy link
Contributor Author

@rjernst done -- let's see how this one turns out.

@colings86
Copy link
Contributor

@elasticmachine test this please

@rjernst rjernst merged commit 8a2b1a7 into elastic:master Aug 10, 2018
@rjernst
Copy link
Member

rjernst commented Aug 10, 2018

Thanks @rationull!

rjernst pushed a commit that referenced this pull request Aug 10, 2018
This change brings the scripted metric agg context docs in line with the new agg state context variable.
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Aug 13, 2018
…listeners

* elastic/master: (58 commits)
  [ML] Partition-wise maximum scores (elastic#32748)
  [DOCS] XContentBuilder#bytes method removed, using BytesReference.bytes(docBuilder) (elastic#32771)
  HLRC: migration get assistance API (elastic#32744)
  Add a task to run forbiddenapis using cli (elastic#32076)
  [Kerberos] Add debug log statement for exceptions (elastic#32663)
  Make x-pack core pull transport-nio (elastic#32757)
  Painless: Clean Up Whitelist Names (elastic#32791)
  Cat apis: Fix index creation time to use strict date format (elastic#32510)
  Clear Job#finished_time when it is opened (elastic#32605) (elastic#32755)
  Test: Only sniff host metadata for node_selectors (elastic#32750)
  Update scripted metric docs to use `state` variable (elastic#32695)
  Painless: Clean up PainlessCast (elastic#32754)
  [TEST] Certificate NONE not allowed in FIPS JVM (elastic#32753)
  [ML] Refactor ProcessCtrl into Autodetect and Normalizer builders (elastic#32720)
  Access build tools resources (elastic#32201)
  Tests: Disable rolling upgrade tests with system key on fips JVM (elastic#32775)
  HLRC: Ban LoggingDeprecationHandler (elastic#32756)
  Fix test reproducability in AbstractBuilderTestCase setup (elastic#32403)
  Only require java<version>_home env var if needed
  Tests: Muted ScriptDocValuesDatesTests.testJodaTimeBwc
  ...
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants