-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PROTO-serialization from IndexMetaData.Custom #32749
Merged
dakrone
merged 23 commits into
elastic:master
from
imotov:remove-proto-from-indexmetadata-custom-2
Aug 30, 2018
Merged
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
3f5d717
Remove PROTO-serialization from IndexMetaData.Custom (II)
imotov b8239f5
Remove automatic xcontent registry discovery
imotov 9986710
Address @dakrone's review comments
imotov d85bd10
Merge remote-tracking branch 'elastic/master' into remove-proto-from-…
imotov 290afc4
Merge remote-tracking branch 'origin/master' into remove-proto-from-i…
dakrone c1fc780
WIP
dakrone 4a95041
Merge remote-tracking branch 'origin/master' into remove-proto-from-i…
dakrone df0f86a
Remove more vestiges
dakrone f4831f2
Fix some things
dakrone 5a471f2
Fix a test
dakrone 08d3a50
AwaitsFix a test until we decide
dakrone b8c9628
Remove most of the REST-facing custom metadata parts
dakrone db11af1
More removals
dakrone ea49b8c
Merge remote-tracking branch 'origin/master' into remove-proto-from-i…
dakrone cd46e81
Implement diffs for DiffableStringMap
dakrone af115fd
Fix NativeRolesStoreTests
dakrone cdb21f9
Fix serialization for pre-7.x versions
dakrone 65c8165
Simplify DiffableStringMap
dakrone 2643723
Return an immutable map from `getCustomData(String)`
dakrone 3d15e60
Remove newline from SPI file
dakrone bf50d45
Remove logging from test
dakrone 6523d40
Add random diffing and serialization test
dakrone 81be184
Make receiving custom metadata throw real exception
dakrone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
registry.isEmpty()
check is superfluous here