Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic AcknowledgedResponse instead of extended classes #32859

Merged
merged 21 commits into from
Aug 15, 2018

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Aug 14, 2018

This removes custom Response classes that extend AcknowledgedResponse and do nothing, these classes are not needed and we can directly use the non-abstract super-class instead.

While this appears to be a large PR, no code has actually changed, only class names have been changed and entire classes removed.

@dakrone dakrone added :Core/Infra/Core Core issues without another label >breaking-java v7.0.0 v6.5.0 labels Aug 14, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is happy, I am happy.

@dakrone dakrone merged commit 48281ac into elastic:master Aug 15, 2018
jasontedor added a commit that referenced this pull request Aug 15, 2018
* elastic/master:
  Revert "cluster formation DSL - Gradle integration -  part 2 (#32028)" (#32876)
  cluster formation DSL - Gradle integration -  part 2 (#32028)
  Introduce global checkpoint listeners (#32696)
  Move connection profile into connection manager (#32858)
  [ML] Temporarily disabling rolling-upgrade tests
  Use generic AcknowledgedResponse instead of extended classes (#32859)
  [ML] Removing old per-partition normalization code (#32816)
  Use JDK 10 for 6.4 BWC builds (#32866)
  Removed flaky test. Looks like randomisation makes these assertions unreliable.
  [test] mute IndexShardTests.testDocStats
  Introduce the dissect library (#32297)
  Security: remove password hash bootstrap check (#32440)
  Move validation to server for put user requests (#32471)
  [ML] Add high level REST client docs for ML put job endpoint (#32843)
  Test: Fix forbidden uses in test framework (#32824)
  Painless: Change fqn_only to no_import (#32817)
  [test] mute testSearchWithSignificantTermsAgg
  Watcher: Remove unused hipchat render method (#32211)
  Watcher: Remove extraneous auth classes (#32300)
  Watcher: migrate PagerDuty v1 events API to v2 API (#32285)
dakrone added a commit that referenced this pull request Aug 15, 2018
This removes custom Response classes that extend `AcknowledgedResponse` and do nothing, these classes are not needed and we can directly use the non-abstract super-class instead.

While this appears to be a large PR, no code has actually changed, only class names have been changed and entire classes removed.
jasontedor added a commit that referenced this pull request Aug 15, 2018
* 6.x:
  Fix global checkpoint listeners test
  HLRC: adding machine learning open job (#32860)
  [ML] Add log structure finder functionality (#32788)
  Use generic AcknowledgedResponse instead of extended classes (#32859)
@dakrone dakrone deleted the dumbify-ackd-responses branch February 4, 2019 14:45
brusic added a commit to brusic/elasticsearch that referenced this pull request Mar 25, 2021
Documentation still refers to DeleteStoredScriptResponse which were removed in elastic#32859
cexbrayat pushed a commit to Ninja-Squad/data-discovery that referenced this pull request Mar 10, 2022
Since ES 6.5 breaks it JAVA API and Spring Data is not up to date (only up to 6.4.3 at this moment), we cannot upgrade ES version to 6.5+ without breaking the application because of: elastic/elasticsearch#32859
I think preferable to keep Spring compatible with the ES internal code instead of keeping it in touch with ES server version. The risk to break the ES High Level API is far lower than breaking internals from ES.
GNP-5408.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants