Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECURITY: Fix Compile Error in ReservedRealmTests #33166

Merged

Conversation

original-brownbear
Copy link
Member

@original-brownbear original-brownbear commented Aug 27, 2018

* This was broken by elastic#32515 since the 5.x versions
were removed between PR creation and merge
@original-brownbear original-brownbear added >non-issue :Security/Security Security issues without another label labels Aug 27, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@original-brownbear original-brownbear changed the title X-PACK: Fix Compile Error in ReservedRealmTests SECURITY: Fix Compile Error in ReservedRealmTests Aug 27, 2018
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can push this immediately to get compilation fixed.

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching and fixing!

@original-brownbear
Copy link
Member Author

@jasontedor @ycombinator thanks, merging right away then:)

@original-brownbear original-brownbear merged commit f7a9186 into elastic:master Aug 27, 2018
@original-brownbear original-brownbear deleted the fix-xpack-compile branch August 27, 2018 13:09
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Aug 27, 2018
* This was broken by elastic#32515 since the 5.x versions
were removed between PR creation and merge
jasontedor added a commit that referenced this pull request Aug 27, 2018
* master:
  Adjust BWC version on mapping version
  Token API supports the client_credentials grant (#33106)
  Build: forked compiler max memory matches jvmArgs (#33138)
  Introduce mapping version to index metadata (#33147)
  SQL: Enable aggregations to create a separate bucket for missing values (#32832)
  Fix grammar in contributing docs
  SECURITY: Fix Compile Error in ReservedRealmTests (#33166)
  APM server monitoring (#32515)
  Support only string `format` in date, root object & date range (#28117)
  [Rollup] Move toBuilders() methods out of rollup config objects (#32585)
  Fix forbiddenapis on java 11  (#33116)
  Apply publishing to genreate pom (#33094)
  Have circuit breaker succeed on unknown mem usage
  Do not lose default mapper on metadata updates (#33153)
  Fix a mappings update test (#33146)
  Reload Secure Settings REST specs & docs (#32990)
  Refactor CachingUsernamePassword realm (#32646)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Security/Security Security issues without another label v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants