Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note discovery-file's deprecation in release notes #33259

Merged

Conversation

DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Aug 30, 2018

This change adds a note about the deprecation of the discovery-file plugin to
the release notes for 6.5. Relates #33241.

This change adds a note about the deprecation of the `discovery-file` plugin to
the release docs for 6.5. Relates elastic#33257
@DaveCTurner DaveCTurner added >docs General docs changes :Distributed/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure v6.5.0 labels Aug 30, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@DaveCTurner
Copy link
Contributor Author

@lcawl my main concern here is that this PR introduces the 6.5 release notes and removes the commented-out text at the top of the 6.4 release notes. I'm not sure what the process is for that but this seemed like the best thing to do.

@lcawl
Copy link
Contributor

lcawl commented Sep 10, 2018

@DaveCTurner I ran a build on this content and it looks good to me. There are some items missing from the 6.4 release notes, but I'll forward-fit those in a separate PR.
Please note: If you haven't already done so, can you add a more verbose description of the breaking changes in this section too?: https://www.elastic.co/guide/en/elasticsearch/reference/6.x/breaking-changes-6.5.html

@DaveCTurner
Copy link
Contributor Author

The failure of the JDK11 build is unrelated to this change; I opened #33579.

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit a6a10be into elastic:6.x Sep 18, 2018
@DaveCTurner DaveCTurner deleted the 2018-08-30-discovery-file-migration-docs branch September 18, 2018 10:59
@DaveCTurner
Copy link
Contributor Author

@lcawl I think there are no breaking changes here - the associated breaking change is #33257 which includes its own additions to the release notes.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker :Distributed/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure >docs General docs changes v6.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants