Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix epoch millis java time formatter #33302

Merged
merged 4 commits into from
Sep 3, 2018
Merged

Core: Fix epoch millis java time formatter #33302

merged 4 commits into from
Sep 3, 2018

Commits on Aug 31, 2018

  1. Core: Fix epoch millis java time formatter 

    The existing implemention could not deal with negative numbers as well
as +- 999 milliseconds around the epoch.

This commit uses Instant.ofEpochMilli() and tries to parse the input to
a number instead of using a date formatter.
    @spinscale
    spinscale committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    64d4952 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into 1808-java-time-fix-epoch-millis-formatter

    @spinscale
    spinscale committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    a72f791 View commit details
    Browse the repository at this point in the history

  3. address review comments

    @spinscale
    spinscale committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    1b5ae9e View commit details
    Browse the repository at this point in the history

  4. minor test changes

    @spinscale
    spinscale committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    246c20c View commit details
    Browse the repository at this point in the history