-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Adds delete forecast API #33401
Conversation
Pinging @elastic/ml-core |
|
||
`forecast_id`:: | ||
(string) A comma-separated list of forecast identifiers. | ||
//TBD: Can this ID be retrieved somehow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID is only available from the initial creation of the forecast.
This API is most likely be utilized from the UI (and they know how to gather and display forecasts from the .ml-shared
index, or as an "oops, I created a forecast via API with the wrong settings".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so there are no immediate plans for a "GET forecasts" API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lcawl no, there is not.
`allow_no_forecasts`:: | ||
(boolean) Whether to ignore if `_all` matches no forecasts. | ||
//TBD: This description is unclear. Does this mean that if this parameter is | ||
//false and there are no forecasts in the job, an error is returned? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, if _all
finds that there are NO forecasts, then an error is returned when this is false
. Rare use case for sure, but is consistent with other APIs that allow this type of interaction.
`timeout`:: | ||
(time units) Controls the time to wait until the forecasts are deleted. | ||
Defaults to 30 seconds. For more information about time units, see <<time-units>>. | ||
//TBD: This description is unclear. Is it the time to wait until the deletion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to wait for the deletion to be complete.
b808bf4
to
c8423ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks a bunch for writing this up @lcawl !!!
Related to #33218 and #31134