Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INGEST: Allow Repeated Invocation of Pipeline #33419

Conversation

original-brownbear
Copy link
Member

  • Allows repeated, non-recursive invocation
    of the same pipeline

Without this change you can't run the following pipeline:

PUT _ingest/pipeline/outer-pipeline
{
  "description" : "outer pipeline",
  "processors" : [
    {
      "pipeline" : {
        "pipeline": "inner-pipeline"
      }
    },
    {
      "pipeline" : {
        "pipeline": "inner-pipeline"
      }
    }
  ]
}

because it will complain about inner-pipeline being executed twice (it incorrectly complains about "recursive" invocation here).
IMO, this should not throw as there may be valid use cases for using the same nested pipeline repeatedly to dry things up.

* Allows repeated, non-recursive invocation
of the same pipeline
@original-brownbear original-brownbear added >non-issue :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v7.0.0 v6.5.0 labels Sep 5, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems likely to be a mistake on a users part, but it certainly shouldn't show up as a recursion. LGTM.

@original-brownbear
Copy link
Member Author

@rjernst thanks!

@original-brownbear original-brownbear merged commit ef1066d into elastic:master Sep 5, 2018
@original-brownbear original-brownbear deleted the allow-repeat-pipeline-invoc branch September 5, 2018 20:04
jakelandis pushed a commit to jakelandis/elasticsearch that referenced this pull request Oct 21, 2018
* Allows repeated, non-recursive invocation
of the same pipeline
jakelandis pushed a commit that referenced this pull request Oct 22, 2018
* Allows repeated, non-recursive invocation
of the same pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >non-issue v6.5.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants