Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Removing unused version.* fields #33584

Conversation

ycombinator
Copy link
Contributor

This PR removes fields that are not actually used by the Monitoring UI. This will greatly simplify the eventual migration to using Metricbeat for monitoring Elasticsearch (see elastic/beats#8260 (comment) for more context and discussion around removing these fields from ES collection).

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@pickypg pickypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just to confirm for others: those fields were never actually picked up on the other side.

@ycombinator
Copy link
Contributor Author

Jenkins, test this

@ycombinator ycombinator force-pushed the x-pack/monitoring/uncollect-unused-fields branch from cac92fa to fdaff1f Compare September 17, 2018 23:00
@ycombinator ycombinator merged commit a95226b into elastic:master Sep 18, 2018
@ycombinator ycombinator deleted the x-pack/monitoring/uncollect-unused-fields branch September 18, 2018 01:30
ycombinator added a commit to ycombinator/elasticsearch that referenced this pull request Sep 18, 2018
This PR removes fields that are not actually used by the Monitoring UI. This will greatly simplify the eventual migration to using Metricbeat for monitoring Elasticsearch (see elastic/beats#8260 (comment) for more context and discussion around removing these fields from ES collection).
ycombinator added a commit that referenced this pull request Sep 18, 2018
* [Monitoring] Removing unused version.* fields (#33584)

This PR removes fields that are not actually used by the Monitoring UI. This will greatly simplify the eventual migration to using Metricbeat for monitoring Elasticsearch (see elastic/beats#8260 (comment) for more context and discussion around removing these fields from ES collection).

* Fixing assertions in integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants