Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Default node.name to the hostname #33677

Merged
merged 11 commits into from
Sep 19, 2018

Commits on Sep 13, 2018

  1. Core: Default node.name to the hostname

    Changes the default of the `node.name` setting to the hostname of the
    machine on which Elasticsearch is running. Previously it was the first 8
    characters of the node id. This had the advantage of producing a unique
    name even when the node name isn't configured but the disadvantage of
    being unrecognizable and not being available until fairly late in the
    startup process. Of particular interest is that it isn't available until
    after logging is configured. This forces us to use a volatile read
    whenever we add the node name to the log.
    
    Using the hostname is available immediately on startup and is generally
    recognizable but has the disadvantage of not being unique when run on
    machines that don't set their hostname or when multiple elasticsearch
    processes are run on the same host. I believe that, taken together, it
    is better to default to the hostname.
    
    1. Running multiple copies of Elasticsearch on the same node is a fairly
    advanced feature. We do it all the as part of the elasticsearch build
    for testing but we make sure to set the node name then.
    2. That the node.name defaults to some flavor of "localhost" on an
    unconfigured box feels like it isn't going to come up too much in
    production. I expect most production deployments to at least set the
    hostname.
    
    As a bonus, production deployments need no longer set the node name in
    most cases. At least in my experience most folks set it to the hostname
    anyway.
    nik9000 committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    4dbcbef View commit details
    Browse the repository at this point in the history
  2. Update docs

    nik9000 committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    605ce74 View commit details
    Browse the repository at this point in the history
  3. Breaking changes doc

    nik9000 committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    5efba9e View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. Configuration menu
    Copy the full SHA
    d240e66 View commit details
    Browse the repository at this point in the history
  2. Remove extra ctor

    nik9000 committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    ae00663 View commit details
    Browse the repository at this point in the history
  3. More cleanup

    nik9000 committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    eb04e04 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2018

  1. Fix test

    nik9000 committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    31707dc View commit details
    Browse the repository at this point in the history
  2. Fixup logger tests

    nik9000 committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    81a0594 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. Configuration menu
    Copy the full SHA
    d2257d1 View commit details
    Browse the repository at this point in the history
  2. Make compile again

    nik9000 committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    1384762 View commit details
    Browse the repository at this point in the history
  3. Fixup asciidoc

    nik9000 committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    74618d5 View commit details
    Browse the repository at this point in the history