-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Default node.name to the hostname #33677
Merged
nik9000
merged 11 commits into
elastic:master
from
nik9000:node_name_defaults_to_host_name
Sep 19, 2018
Merged
Core: Default node.name to the hostname #33677
nik9000
merged 11 commits into
elastic:master
from
nik9000:node_name_defaults_to_host_name
Sep 19, 2018
Commits on Sep 13, 2018
-
Core: Default node.name to the hostname
Changes the default of the `node.name` setting to the hostname of the machine on which Elasticsearch is running. Previously it was the first 8 characters of the node id. This had the advantage of producing a unique name even when the node name isn't configured but the disadvantage of being unrecognizable and not being available until fairly late in the startup process. Of particular interest is that it isn't available until after logging is configured. This forces us to use a volatile read whenever we add the node name to the log. Using the hostname is available immediately on startup and is generally recognizable but has the disadvantage of not being unique when run on machines that don't set their hostname or when multiple elasticsearch processes are run on the same host. I believe that, taken together, it is better to default to the hostname. 1. Running multiple copies of Elasticsearch on the same node is a fairly advanced feature. We do it all the as part of the elasticsearch build for testing but we make sure to set the node name then. 2. That the node.name defaults to some flavor of "localhost" on an unconfigured box feels like it isn't going to come up too much in production. I expect most production deployments to at least set the hostname. As a bonus, production deployments need no longer set the node name in most cases. At least in my experience most folks set it to the hostname anyway.
Configuration menu - View commit details
-
Copy full SHA for 4dbcbef - Browse repository at this point
Copy the full SHA 4dbcbefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 605ce74 - Browse repository at this point
Copy the full SHA 605ce74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5efba9e - Browse repository at this point
Copy the full SHA 5efba9eView commit details
Commits on Sep 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for d240e66 - Browse repository at this point
Copy the full SHA d240e66View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae00663 - Browse repository at this point
Copy the full SHA ae00663View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb04e04 - Browse repository at this point
Copy the full SHA eb04e04View commit details
Commits on Sep 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 31707dc - Browse repository at this point
Copy the full SHA 31707dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 81a0594 - Browse repository at this point
Copy the full SHA 81a0594View commit details
Commits on Sep 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for d2257d1 - Browse repository at this point
Copy the full SHA d2257d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1384762 - Browse repository at this point
Copy the full SHA 1384762View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74618d5 - Browse repository at this point
Copy the full SHA 74618d5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.