[ML] Leniently parse ml persistent task parameters #33950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
benwtrent
approved these changes
Sep 21, 2018
|
retest this please |
davidkyle
force-pushed
the
lenient-parsing-ptask-params
branch
from
3168146
to
053cf4e
Compare
davidkyle
force-pushed
the
lenient-parsing-ptask-params
branch
from
053cf4e
to
bbf8c2f
Compare
davidkyle
added a commit
that referenced
this pull request
Sep 25, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore unknown fields when parsing the job and datafeed persistent task parameters.
This is required for migrating the ml configuration work #32905 where additional fields will be added to the task parameters (as the config won't be available in the cluster state) and those fields need to be safely parsed during a rolling upgrade to 7.0