Core: Remove two methods from AbstractComponent #34336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes another two methods from `AbstractComponent`. One isn't used at all and another is only used in a single class in watcher. I've moved the method that watcher uses into the single class that uses it.
nik9000
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
|
I talked to @jasontedor today who suggested removing the watcher invocation of this method. These settings are very old and we've warned about them for a few major versions. |
|
Thanks for reviewing @rjernst! I've merged and will backport to 6.x. |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 15, 2018
* master: Do not update number of replicas on no indices (elastic#34481) Core: Remove two methods from AbstractComponent (elastic#34336) Use RoleRetrievalResult for better caching (elastic#34197) Revert "Search: Fix spelling mistake in Javadoc (elastic#34480)" Search: Fix spelling mistake in Javadoc (elastic#34480) Docs: improve formatting of Query String Query doc page (elastic#34432) Tests: Handle epoch date formatters edge cases (elastic#34437) Test: Fix running with external cluster Fix handling of empty keyword in terms aggregation (elastic#34457) [DOCS] Fix tag in SecurityDocumentationIT [Monitoring] Add additional necessary mappings for apm-server (elastic#34392) SCRIPTING: Move Aggregation Script Context to its own class (elastic#33820) MINOR: Remove Deadcode in ExpressionTermSetQuery (elastic#34442) HLRC: Get SSL Certificates API (elastic#34135)
nik9000
added a commit
that referenced
this pull request
Oct 16, 2018
This removes another two methods from `AbstractComponent`. One isn't used at all and another is only used in a single class in watcher. I've moved the method that watcher uses into the single class that uses it.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This removes another two methods from `AbstractComponent`. One isn't used at all and another is only used in a single class in watcher. I've moved the method that watcher uses into the single class that uses it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes another two methods from
AbstractComponent. One isn'tused at all and another is only used in a single class in our resource
watcher to log messages about settings we removed years ago. I've
dropped the logging and removed that method as well.