Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and deprecated prefix logfile audit setting names #34475

Conversation

albertzaharovits
Copy link
Contributor

#31931 Changed the format of the logfile audit log.
It is no longer formed by prefix fields followed by key value fields, it is all formed by key value fields only (JSON format).

Consequently, the following settings, which toggled some of the prefix fields, should be renamed:
audit.logfile .prefix.emit_node_host_address
audit.logfile .prefix.emit_node_host_name
audit.logfile .prefix.emit_node_name
The prefix variants have been deprecated (in 7.0 also?) in favor of the variants lacking the prefix. .

The setting audit.logfile.prefix.emit_node_id which has not seen the release light has simply been renamed to audit.logfile.emit_node_id .

Relates #31931 (should have been considered there).

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM. When you backport we need to document the deprecation of these settings in the migrate_6_5.asciidoc file. Also, please open a followup PR that removes the deprecated settings from master and documents the removal as a breaking change for 7.0

@albertzaharovits albertzaharovits merged commit df3726d into elastic:master Oct 18, 2018
@albertzaharovits albertzaharovits deleted the deprecated_logfile_audit_prefix_settings branch October 18, 2018 09:06
albertzaharovits added a commit that referenced this pull request Oct 18, 2018
The logfile audit log format is no longer formed by prefix fields followed
by key value fields, it is all formed by key value fields only (JSON format).

Consequently, the following settings, which toggled some of the prefix
fields, have been renamed by splicing out the prefix component:
- xpack.security.audit.logfile.prefix.emit_node_host_address
- xpack.security.audit.logfile.prefix.emit_node_host_name
- xpack.security.audit.logfile.prefix.emit_node_name
albertzaharovits added a commit that referenced this pull request Oct 19, 2018
CI for #34475 ran successfuly but 6.x did
not had #33894 merged in yet.

Closes #34627
kcm pushed a commit that referenced this pull request Oct 30, 2018
The logfile audit log format is no longer formed by prefix fields followed
by key value fields, it is all formed by key value fields only (JSON format).

Consequently, the following settings, which toggled some of the prefix
fields, have been renamed:
audit.logfile .prefix.emit_node_host_address
audit.logfile .prefix.emit_node_host_name
audit.logfile .prefix.emit_node_name
albertzaharovits added a commit that referenced this pull request Dec 3, 2018
I have botched deprecating the "prefix" logfile audit settings
in #34475 , by not registering them.
This commit fixes it and also adds a test that these deprecated
settings are indeed still working and are dynamic.

Closes #36162
albertzaharovits added a commit that referenced this pull request Dec 4, 2018
I have botched deprecating the "prefix" logfile audit settings
in #34475 , by not registering them.
This commit fixes it and also adds a test that these deprecated
settings are indeed still working and are dynamic.

Closes #36162
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants