Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest: document index.default_pipeline #34500

Merged
merged 7 commits into from
Oct 23, 2018

Conversation

jakelandis
Copy link
Contributor

No description provided.

@jakelandis jakelandis added >docs General docs changes :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v7.0.0 v6.5.0 labels Oct 15, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakelandis
Copy link
Contributor Author

@original-brownbear - I forgot to call out this option in the ingest node documentation.

Can you please take another look ?
Specifically 66f033c (I rendered the doc and the link works fine)

@original-brownbear
Copy link
Member

Still LGTM :)

@rjernst
Copy link
Member

rjernst commented Oct 18, 2018

Is the override of pipeline=_none mentioned somewhere already?

@jakelandis
Copy link
Contributor Author

@rjernst

Is the override of pipeline=_none mentioned somewhere already?

Nope, it isn't mentioned. I can add to this PR.

how about:

 `index.default_pipeline`::
    The default <<ingest,ingest node>> pipeline for this index. Index requests will fail
    if the default pipeline is set and the pipeline does not exist. The default may be 
    be ignored per request by setting the request parameter `pipeline=_none`. 

@jakelandis
Copy link
Contributor Author

Updated PR to include mention of pipeline=_none.

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one suggestion.


The default <<ingest,ingest node>> pipeline for this index. Index requests will fail
if the default pipeline is set and the pipeline does not exist. The default may be
ignored per request by setting the request parameter `pipeline=_none`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggestion something like this in place of the last sentence:

The default may be overridden using the `pipeline` parameter. The special pipeline name `_none` indicates no ingest pipeline should be run.

The point is to show that pipeline can be specified in general to override the default, and that _none is just a special pipeline name.

@jakelandis jakelandis merged commit 067d135 into elastic:master Oct 23, 2018
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Oct 23, 2018
@jakelandis
Copy link
Contributor Author

6.5 backport: e0ee802

@colings86 colings86 removed the v7.0.0 label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes v6.5.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants