Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: handle X-Pack or X-Pack SQL not being available in a more graceful way #34736

Merged
merged 9 commits into from
Oct 25, 2018
Merged

SQL: handle X-Pack or X-Pack SQL not being available in a more graceful way #34736

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cae0e67
Handle 400 http response from ES (used when x-pack is not installed and
astefan Oct 23, 2018
a4a5e08
Changed the error message to accurately cover all scenarios
astefan Oct 23, 2018
9fb6094
Merge branch 'master' of https://github.com/elastic/elasticsearch int…
astefan Oct 23, 2018
3f4d180
Added the proxy issues hint in the error message.
astefan Oct 23, 2018
79f6361
Rephrased the error message
astefan Oct 24, 2018
ccdc39e
Merge branch 'master' of https://github.com/elastic/elasticsearch int…
astefan Oct 24, 2018
0604139
Added one more condition for checking the availability of XPack and SQL
astefan Oct 24, 2018
0a13d7a
Merge branch 'master' of https://github.com/elastic/elasticsearch int…
astefan Oct 24, 2018
103aeff
Merge branch 'master' of https://github.com/elastic/elasticsearch int…
astefan Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...sql/sql-client/src/main/java/org/elasticsearch/xpack/sql/client/JreHttpUrlConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,16 @@ private <R> ResponseOrException<R> parserError() throws IOException {
}
SqlExceptionType type = SqlExceptionType.fromRemoteFailureType(failure.type());
if (type == null) {
if (con.getResponseCode() == HttpURLConnection.HTTP_BAD_REQUEST) {
return new ResponseOrException<>(new SQLException("It doesn't look like the X-Pack or the X-Pack SQL component"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight rephrasing, removing some the and typos: X-Pack/ SQL do not seem to be available on the Elasticsearch node using the access path '...' . Please verify X-Pack is installed and SQL enabled. Alternatively, check if any proxy is interfering the communication to Elasticsearch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I modified it.

+ " are available on this Elasticsearch node using the access path '"
+ con.getURL().getHost()
+ (con.getURL().getPort() > 0 ? ":" + con.getURL().getPort() : "")
+ "'."
+ " Please verify that X-Pack is installed and SQL enabled; alternatively, check if any proxy is interferring"
+ " with the SQL request to Elasticsearch",
SQL_STATE_BAD_SERVER));
}
return new ResponseOrException<>(new SQLException("Server sent bad type ["
+ failure.type() + "]. Original type was [" + failure.reason() + "]. ["
+ failure.remoteTrace() + "]", SQL_STATE_BAD_SERVER));
Expand Down