Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce a [skip] when using [contains] #34840

Merged
merged 2 commits into from
Oct 29, 2018

Conversation

alpar-t
Copy link
Contributor

@alpar-t alpar-t commented Oct 25, 2018

Ensures that we are friendly with other runners that may not have implemented the feature.

Be friendly to other runners
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @atorok

@alpar-t
Copy link
Contributor Author

alpar-t commented Oct 25, 2018

@elasticmachine test this please

@colings86 colings86 added v6.6.0 and removed v6.5.0 labels Oct 25, 2018
@alpar-t alpar-t merged commit baa144e into elastic:master Oct 29, 2018
@alpar-t alpar-t deleted the force-skip-when-using-contains branch October 29, 2018 12:54
@alpar-t
Copy link
Contributor Author

alpar-t commented Oct 29, 2018

Back-port pending on #34693

kcm pushed a commit that referenced this pull request Oct 30, 2018
@javanna
Copy link
Member

javanna commented Nov 1, 2018

@atorok you can backport now ;)

alpar-t added a commit that referenced this pull request Nov 1, 2018
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v6.6.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants