Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename CRUD api REST path prefix _ilm to _ilm/policy #35056

Merged
merged 6 commits into from
Oct 30, 2018
Merged

rename CRUD api REST path prefix _ilm to _ilm/policy #35056

merged 6 commits into from
Oct 30, 2018

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Oct 29, 2018

This PR renames the CRUD APIS for ILM

GET _ilm/, _ilm -> _ilm/policy/, _ilm/policy
PUT _ilm/ -> _ilm/policy/
DELETE _ilm/ -> _ilm/policy/

closes #34929.

@talevy talevy added >non-issue >refactoring :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Oct 29, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@dakrone
Copy link
Member

dakrone commented Oct 29, 2018

I feel like this is missing the documentation changes also? Shouldn't we have some docs somewhere referencing this that need to change?

@talevy
Copy link
Contributor Author

talevy commented Oct 29, 2018

indeed @dakrone, I forgot to test the docs :(. pushed the doc changes up now!

dakrone
dakrone approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy

gwbrown
gwbrown reviewed Oct 29, 2018
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talevy
Copy link
Contributor Author

talevy commented Oct 29, 2018

test this please

colings86
colings86 approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talevy talevy merged commit 5141084 into elastic:index-lifecycle Oct 30, 2018
@talevy talevy deleted the ilm-policy branch October 30, 2018 23:19
talevy added a commit that referenced this pull request Oct 30, 2018
@talevy
rename CRUD api REST path prefix _ilm to _ilm/policy (#35056)
15fe224 
This PR renames the CRUD APIS for ILM

GET _ilm/<policy>, _ilm -> _ilm/policy/<policy>, _ilm/policy
PUT _ilm/<policy> -> _ilm/policy/<policy>
DELETE _ilm/<policy> -> _ilm/policy/<policy>

closes #34929.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwbrown gwbrown gwbrown left review comments

@colings86 colings86 colings86 approved these changes

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >non-issue >refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@talevy @elasticmachine @dakrone @colings86 @gwbrown