Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ILM integ test cluster poll interval to 1s #35113

Merged
merged 8 commits into from
Nov 1, 2018
Merged

update ILM integ test cluster poll interval to 1s #35113

merged 8 commits into from
Nov 1, 2018

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Oct 31, 2018

To test a theory for #35105, I am opening this
to see how it behaves in CI.

More logging is also necessary to see how to resolve this consistently, beyond timing magic.

@talevy talevy added >test Issues or PRs that are addressing/adding tests WIP :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Oct 31, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@talevy talevy changed the title update IT poll interval to 1s update ILM integ test cluster poll interval to 1s Oct 31, 2018
@talevy
Copy link
Contributor Author

talevy commented Oct 31, 2018

test this please

1 similar comment
@talevy
Copy link
Contributor Author

talevy commented Oct 31, 2018

test this please

@talevy talevy removed the WIP label Oct 31, 2018
gwbrown
gwbrown requested changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I think we should document why the order is the way it is if the order matters to timing though.

...-node/src/test/java/org/elasticsearch/xpack/indexlifecycle/TimeSeriesLifecycleActionsIT.java
assertBusy(() -> assertFalse(indexExists(originalIndex)));
assertBusy(() -> assertFalse(indexExists(shrunkenOriginalIndex)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the order of these asserts is important in a non-obvious way, we should probably include a comment explaining why.

...-node/src/test/java/org/elasticsearch/xpack/indexlifecycle/TimeSeriesLifecycleActionsIT.java
assertBusy(() -> assertFalse(indexExists(originalIndex)));
assertBusy(() -> assertFalse(indexExists(shrunkenOriginalIndex)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the order of these asserts is important in a non-obvious way, we should probably include a comment explaining why.

@talevy
Copy link
Contributor Author

talevy commented Oct 31, 2018

thank you @gwbrown, I've updated with docs!

@gwbrown
Copy link
Contributor

gwbrown commented Oct 31, 2018 •
edited
Loading

While those docs are good, what I meant was something more like:

// These asserts are in the order that they should be satisfied in, in 
// order to maximize the time for all operations to complete. 
// An "out of order" assert here may result in this test occasionally 
// timing out and failing inappropriately.

Sorry I wasn't clear!

@talevy
Copy link
Contributor Author

talevy commented Oct 31, 2018

thank you @gwbrown. added in the extra context you mentioned about ordering
alongside the existing!

gwbrown
gwbrown approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@talevy talevy merged commit f8e23f6 into elastic:index-lifecycle Nov 1, 2018
@talevy talevy deleted the ilm-test-35105 branch November 1, 2018 00:09
talevy added a commit that referenced this pull request Nov 1, 2018
@talevy
update ILM integ test cluster poll interval to 1s (#35113)
a0f1214
@colings86 colings86 mentioned this pull request Nov 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwbrown gwbrown gwbrown approved these changes

@dakrone dakrone Awaiting requested review from dakrone

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@talevy @elasticmachine @gwbrown