Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade 6.x to lucene-7.6.0-snapshot-f9598f335b #35225

Merged
merged 1 commit into from
Nov 4, 2018
Merged

Upgrade 6.x to lucene-7.6.0-snapshot-f9598f335b #35225

merged 1 commit into from
Nov 4, 2018

Conversation

nknize
Copy link
Contributor

@nknize nknize commented Nov 2, 2018

This PR upgrades the 6.x branch to lucene-7.6.0-snapshot-f9598f335b to expose latest BKD backed geoshape improvements.

@dnhatn dnhatn added the :Search/Search Search-related issues that do not fall into other categories label Nov 3, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

dnhatn
dnhatn approved these changes Nov 3, 2018
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nknize nknize merged commit 542a3f6 into elastic:6.x Nov 4, 2018
@dnhatn
Copy link
Member

dnhatn commented Nov 4, 2018

It looks like we pulled this in too earlier. We need to upgrade the master first. The BWC build is failing. I will look into this and revert this commit if required.

Caused by: org.apache.lucene.index.IndexFormatTooNewException: Format version is not supported (resource BufferedChecksumIndexInput(MMapIndexInput(path="/var/lib/jenkins/workspace/elastic+elasticsearch+master+default-distro-bwc-tests/qa/full-cluster-restart/build/cluster/v6.6.0#oldClusterTestCluster node0/elasticsearch-6.6.0-SNAPSHOT/data/nodes/0/indices/MBIt9YH4Rk--ijCSQbb8Pw/1/index/_0.cfs") [slice=_0.fnm])): 2 (needs to be between 0 and 1)

dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Nov 5, 2018
@dnhatn
Revert "Upgrade to Lucene-7.6.0-snapshot-f9598f335b (elastic#35225)"
81daf4c 
We need to upgrade the master first; otherwise 7.0 won't
understand the new format in 6.x.
This reverts commit 542a3f6.
@dnhatn
Copy link
Member

dnhatn commented Nov 5, 2018

@nknize I have to revert this commit in 6.x as BWC build is failing. Please re-commit after we upgraded a new Lucene snapshot into the master (#35224). Thank you!

@nknize
Copy link
Contributor Author

nknize commented Nov 5, 2018

Hrm.. no worries and thx @dnhatn I reopen a PR after we merge #35224

jimczi added a commit that referenced this pull request Nov 6, 2018
@jimczi
Restore "Upgrade to Lucene-7.6.0-snapshot-f9598f335b (#35225)"
fd6dba7 
This commit restores the upgrade to Lucene-7.6.0 snapshot that was reverted by
81daf4c.
The change should work now that master has been upgraded to a recent Lucene 8 snapshot.
@jimczi jimczi mentioned this pull request Nov 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnhatn dnhatn dnhatn approved these changes

Assignees
No one assigned
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nknize @elasticmachine @dnhatn