Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Azure max_retries setting #35286

Merged
merged 3 commits into from
Nov 6, 2018
Merged

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Nov 6, 2018

The Azure max_retries setting, mentioned in the [documentation](url
https://www.elastic.co/guide/en/elasticsearch/plugins/6.x/repository-azure.html), is not properly registered. Note that after adding settings validation to the tests, this was caught by the existing test testGetSelectedClientBackoffPolicyNbRetries.

@ywelsch ywelsch added >bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v7.0.0 v6.6.0 v6.5.1 labels Nov 6, 2018
@ywelsch ywelsch requested a review from tlrx November 6, 2018 08:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywelsch
Copy link
Contributor Author

ywelsch commented Nov 6, 2018

@elasticmachine run packaging tests please

@ywelsch
Copy link
Contributor Author

ywelsch commented Nov 6, 2018

@elasticmachine run sample packaging tests

@ywelsch ywelsch merged commit a4b26fe into elastic:master Nov 6, 2018
ywelsch added a commit that referenced this pull request Nov 6, 2018
This commit properly registers the Azure max_retries setting in the settings infrastructure,
allowing this setting to be actually used.
ywelsch added a commit that referenced this pull request Nov 6, 2018
This commit properly registers the Azure max_retries setting in the settings infrastructure,
allowing this setting to be actually used.
matarrese added a commit to matarrese/elasticsearch that referenced this pull request Nov 6, 2018
…-agg

* master: (528 commits)
  Register Azure max_retries setting (elastic#35286)
  add version 6.4.4
  [Docs] Add painless context details for bucket_script (elastic#35142)
  Upgrade jline to 3.8.2 (elastic#35288)
  SQL: new SQL CLI logo (elastic#35261)
  Logger: Merge ESLoggerFactory into Loggers (elastic#35146)
  Docs: Add section about range query for range type (elastic#35222)
  [ILM] change remove-policy-from-index http method from DELETE to POST (elastic#35268)
  [CCR] Forgot missing return statement,
  SQL: Fix null handling for AND and OR in SELECT (elastic#35277)
  [TEST] Mute ChangePolicyForIndexIT#testChangePolicyForIndex
  Serialize ignore_throttled also to 6.6 after backport
  Check for java 11 in buildSrc (elastic#35260)
  [TEST] increase await timeout in RemoteClusterConnectionTests
  Add missing up-to-date configuration (elastic#35255)
  Adapt Lucene BWC version
  SQL: Introduce Coalesce function (elastic#35253)
  Upgrade to lucene-8.0.0-snapshot-31d7dfe6b1 (elastic#35224)
  Fix failing ICU tests (elastic#35207)
  Prevent throttled indices to be searched through wildcards by default (elastic#34354)
  ...
@colings86 colings86 added v6.5.0 and removed v6.5.1 labels Nov 9, 2018
pgomulka pushed a commit to pgomulka/elasticsearch that referenced this pull request Nov 13, 2018
This commit properly registers the Azure max_retries setting in the settings infrastructure,
allowing this setting to be actually used.
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v6.5.0 v6.6.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants