Deprecate negative scores in functon_score query #35865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to elastic#33309, backport for elastic#35709
mayya-sharipova
added
backport
>deprecation
v6.6.0
:Search Relevance/Ranking
|
Pinging @elastic/es-search |
jimczi
approved these changes
Nov 23, 2018
| @@ -153,6 +153,9 @@ GET /_search | |||
| // CONSOLE | |||
| // TEST[setup:twitter] | |||
|
|
|||
| NOTE: Scores produced by the `script_score` function must be non-negative, | |||
There was a problem hiding this comment.
you can maybe make it a WARNING: ?
| @@ -324,6 +327,9 @@ There are a number of options for the `field_value_factor` function: | |||
| values of the field with a range filter to avoid this, or use `log1p` and | |||
| `ln1p`. | |||
|
|
|||
| NOTE: Scores produced by the `field_value_score` function must be | |||
…nonnegative-scores-6.x
mayya-sharipova
deleted the
script-score-ensure-nonnegative-scores-6.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #33309, backport for #35709