[ILM] reduce time restriction on IndexLifecycleExplainResponse #35954
Conversation
step times were set. The assumption was that these are always set. Tests passed, which led me to believe this was true. There is a time when shrunk indices have their step phase/action/step details set, but with no time information (in the CopyExecutionStateStep). Explain API fails for these
talevy
added
>bug
blocker
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-features |
|
I've opened this to discuss an alternative solution that the original commit in the PR does not address. That is to have CopyExecutionStateStep set phase_time,action_time,step_time. To be on the safe side, since this is very cosmetic, I went with just making the constructor more lenient |
|
CopyExecutionStateStep should probably copy the times as well - the whole idea is to have the shrunken index completely replace the original, so it should take the times with it. |
|
@gwbrown I agree. I also think a part of that change should add validation of null values for these relevant fields in the LifecycleExecutionState constructor. I am also not sure what the correct step_time. the best estimate is the time of the step from the original index. |
|
test this please |
step times were set. The assumption was that these are always set. Tests passed, which led me to believe this was true. There is a time when shrunk indices have their step phase/action/step details set, but with no time information (in the CopyExecutionStateStep). Explain API fails for these
* master: DOCS Audit event attributes in new format (elastic#35510) Scripting: Actually add joda time back to whitelist (elastic#35965) [DOCS] fix HLRC ILM doc misreferenced tag Add realm information for Authenticate API (elastic#35648) [ILM] add HLRC docs to remove-policy-from-index (elastic#35759) [Rollup] Update serialization version after backport [Rollup] Add more diagnostic stats to job (elastic#35471) Build: Fix gradle build for Mac OS (elastic#35968) Adds deprecation logging to ScriptDocValues#getValues. (elastic#34279) [Monitoring] Make Exporters Async (elastic#35765) [ILM] reduce time restriction on IndexLifecycleExplainResponse (elastic#35954) Remove use of AbstractComponent in xpack (elastic#35394) Deprecate types in search and multi search templates. (elastic#35669) Remove fromXContent from IndexUpgradeInfoResponse (elastic#35934)
step times were set. The assumption was that these are always set.
Tests passed, which led me to believe this was true. There is a time
when shrunk indices have their step phase/action/step details set,
but with no time information (in the CopyExecutionStateStep).
Explain API fails for these