[ILM] [DOCS] add general info about steps #36081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is important for users to understand that phases are compiled into Steps that are exposed via the Explain Lifecycle API.
talevy
added
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-features |
colings86
requested changes
Dec 3, 2018
Co-Authored-By: talevy <JubBoy333@gmail.com>
colings86
requested changes
Dec 4, 2018
| in the index's metadata. The phase and its actions are compiled into a series | ||
| of discrete steps that are executed. Since some {ILM} actions are more complex | ||
| and involve multiple actions against an index, each of these are done in their | ||
| own step. This provides better visibility into the execution of the phases. The |
There was a problem hiding this comment.
This provides better visibility into the execution of the phases -> I'm not sure about this sentence since this is not actually the reason we have steps (Though it is the reason why we expose steps in the ILM explain API). The reason we split the actions into steps is so we have better control over the execution of the lifecycle and so we know exactly which operations have been executed and which are still to be done.
There was a problem hiding this comment.
another sentence that is unnecessary
Co-Authored-By: talevy <JubBoy333@gmail.com>
Co-Authored-By: talevy <JubBoy333@gmail.com>
colings86
approved these changes
Dec 5, 2018
talevy
added a commit
that referenced
this pull request
Dec 6, 2018
it is important for users to understand that phases are compiled into Steps that are exposed via the Explain Lifecycle API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is important for users to understand that phases
are compiled into Steps that are exposed via the
Explain Lifecycle API.
related to #34937