Undeprecate /_watcher endpoints #36269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We deprecated these awhile ago in favor of /_xpack/watcher endpoints. Yet, this is no longer the direction that we want to go in, instead we want to remove the /_xpack namespace. This commit undeprecates the /_watcher endpoint.
|
Pinging @elastic/es-core-features |
hub-cap
commented
Dec 5, 2018
| @@ -30,12 +30,17 @@ public RestWatchServiceAction(Settings settings, RestController controller) { | |||
|
|
|||
| // @deprecated Remove in 6.0 | |||
| // NOTE: we switched from PUT in 2.x to POST in 5.x | |||
| // NOTE: We added back the old URL with the new VERB (POST) since we are deprecating _xpack/* URIs in 7.0 | |||
There was a problem hiding this comment.
im not 100% sure i did this right. Should I instead put both the PUT and POST back to non deprecated? In 7, only POST /_watcher and POST /_xpack/watcher exist, so this is why I did not undeprecate the PUT /_watcher
|
@jasontedor I believe I will have to also backport this to 6.5 because master will test against both 6.6.0 and 6.5.latest, right? I did not see the changes you made for disregard: looks like the build is passing w/o these, the problem was a issue w/ our build testing against every bwc build ever. |
|
@elasticmachine run the gradle build tests 2 |
1 similar comment
|
@elasticmachine run the gradle build tests 2 |
jasontedor
approved these changes
Dec 7, 2018
| @@ -41,14 +41,14 @@ public RestActivateWatchAction(Settings settings, RestController controller) { | |||
| final DeactivateRestHandler deactivateRestHandler = new DeactivateRestHandler(settings); | |||
|
|
|||
| // @deprecated Remove deprecations in 6.0 | |||
| @@ -38,14 +38,14 @@ | |||
| public RestAckWatchAction(Settings settings, RestController controller) { | |||
| super(settings); | |||
| // @deprecated Remove deprecations in 6.0 | |||
| @@ -34,8 +34,8 @@ | |||
| public RestDeleteWatchAction(Settings settings, RestController controller) { | |||
| super(settings); | |||
| // @deprecated Remove deprecations in 6.0 | |||
| @@ -57,14 +57,14 @@ public RestExecuteWatchAction(Settings settings, RestController controller) { | |||
| super(settings); | |||
|
|
|||
| // @deprecated Remove deprecations in 6.0 | |||
| @@ -35,8 +35,8 @@ public RestGetWatchAction(Settings settings, RestController controller) { | |||
| super(settings); | |||
|
|
|||
| // @deprecated Remove deprecations in 6.0 | |||
| @@ -41,10 +41,10 @@ public RestPutWatchAction(Settings settings, RestController controller) { | |||
| super(settings); | |||
|
|
|||
| // @deprecated Remove deprecations in 6.0 | |||
| @@ -30,12 +30,17 @@ public RestWatchServiceAction(Settings settings, RestController controller) { | |||
|
|
|||
| // @deprecated Remove in 6.0 | |||
| // NOTE: we switched from PUT in 2.x to POST in 5.x | |||
| // NOTE: We added back the old URL with the new VERB (POST) since we are deprecating _xpack/* URIs in 7.0 | |||
| @@ -30,12 +30,17 @@ public RestWatchServiceAction(Settings settings, RestController controller) { | |||
|
|
|||
| // @deprecated Remove in 6.0 | |||
| @@ -31,10 +31,10 @@ public RestWatcherStatsAction(Settings settings, RestController controller) { | |||
| super(settings); | |||
|
|
|||
| // @deprecated Remove deprecations in 6.0 | |||
jasontedor
added a commit
to liketic/elasticsearch
that referenced
this pull request
Dec 9, 2018
* elastic/6.x: (37 commits) [HLRC] Added support for Follow Stats API (elastic#36253) Exposed engine must have all ops below gcp during rollback (elastic#36159) TEST: Always enable soft-deletes in ShardChangesTests Use delCount of SegmentInfos to calculate numDocs (elastic#36323) Add soft-deletes upgrade tests (elastic#36286) Remove LocalCheckpointTracker#resetCheckpoint (elastic#34667) Option to use endpoints starting with _security (elastic#36379) [CCR] Restructured QA modules (elastic#36404) RestClient: on retry timeout add root exception (elastic#25576) [HLRC] Add support for put privileges API (elastic#35679) HLRC: Add rollup search (elastic#36334) Explicitly recommend to forceMerge before freezing (elastic#36376) Rename internal repository actions to be internal (elastic#36377) Core: Remove parseDefaulting from DateFormatter (elastic#36386) [ML] Prevent stack overflow while copying ML jobs and datafeeds (elastic#36370) Docs: Fix Jackson reference (elastic#36366) [ILM] Fix issue where index may not yet be in 'hot' phase (elastic#35716) Undeprecate /_watcher endpoints (elastic#36269) Docs: Fix typo in bool query (elastic#36350) HLRC: Add delete template API (elastic#36320) ...
11 tasks
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We deprecated these awhile ago in favor of /_xpack/watcher
endpoints. Yet, this is no longer the direction that we want to go in,
instead we want to remove the /_xpack namespace. This commit
undeprecates the /_watcher endpoint.