Modify SHA-1 matcher in Docker version output #36706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Docker version (docker --version) contains the SHA-1 of the commit used for the build. This commit can be represented as short hash, but not necessarily limited to seven characters. This commit modifies the regular expression used to match the SHA-1 so that we do not fail on builds that use a longer hash.
jasontedor
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
|
I also just opened #36707 to address this, sorry didn't look at the time and did not realize that you could already be looking at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docker version (docker --version) contains the SHA-1 of the commit used for the build. This commit can be represented as short hash, but not necessarily limited to seven characters. This commit modifies the regular expression used to match the SHA-1 so that we do not fail on builds that use a longer hash.
Closes #36414