-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URI to cluster stats endpoint on specific nodes #36784
Merged
DaveCTurner
merged 3 commits into
elastic:master
from
DaveCTurner:2018-12-18-fix-cluster-stats-nodes-filter-docs
Dec 21, 2018
Merged
Fix URI to cluster stats endpoint on specific nodes #36784
DaveCTurner
merged 3 commits into
elastic:master
from
DaveCTurner:2018-12-18-fix-cluster-stats-nodes-filter-docs
Dec 21, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
added
>docs
General docs changes
:Data Management/Stats
Statistics tracking and retrieval APIs
v7.0.0
v6.6.0
v6.4.4
v6.5.5
labels
Dec 18, 2018
Pinging @elastic/es-core-features |
ywelsch
approved these changes
Dec 20, 2018
@@ -225,11 +225,11 @@ Will return, for example: | |||
// the response are ignored. So we're really only asserting things about the | |||
// the shape of this response, not the values in it. | |||
|
|||
This API can be restricted to a subset of the nodes using the `?nodeId` | |||
parameter, which accepts <<cluster-nodes,node filters>>: | |||
This API can be restricted to a subset of the nodes as follows, using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave out the "as follows" part, but that's just a preference.
DaveCTurner
deleted the
2018-12-18-fix-cluster-stats-nodes-filter-docs
branch
December 21, 2018 13:52
DaveCTurner
added a commit
that referenced
this pull request
Dec 21, 2018
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 21, 2018
DaveCTurner
added a commit
that referenced
this pull request
Dec 21, 2018
DaveCTurner
added a commit
that referenced
this pull request
Dec 21, 2018
jasontedor
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Dec 21, 2018
* elastic/master: (539 commits) SQL: documentation improvements and updates (elastic#36918) [DOCS] Merges list of discovery and cluster formation settings (elastic#36909) Only compress responses if request was compressed (elastic#36867) Remove duplicate paragraph (elastic#36942) Fix URI to cluster stats endpoint on specific nodes (elastic#36784) Fix typo in unitTest task (elastic#36930) RecoveryMonitor#lastSeenAccessTime should be volatile (elastic#36781) [CCR] Add `ccr.auto_follow_coordinator.wait_for_timeout` setting (elastic#36714) Scripting: Remove deprecated params.ctx (elastic#36848) Refactor the REST actions to clarify what endpoints are deprecated. (elastic#36869) Add JDK 12 to CI rotation (elastic#36915) Improve error message for 6.x style realm settings (elastic#36876) Send clear session as routable remote request (elastic#36805) [DOCS] Remove redundant ILM attributes (elastic#36808) SQL: Fix bug regarding histograms usage in scripting (elastic#36866) Update index mappings when ccr restore complete (elastic#36879) Docs: Bump version to alpha2 after release Enable IPv6 URIs in reindex from remote (elastic#36874) Watcher: Remove unused local variable in doExecute (elastic#36655) [DOCS] Synchs titles of X-Pack APIs ...
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Dec 21, 2018
* master: (31 commits) Move ingest-geoip default databases out of config (elastic#36949) [ILM][DOCS] add extra scenario to policy update docs (elastic#36871) [Painless] Add String Casting Tests (elastic#36945) SQL: documentation improvements and updates (elastic#36918) [DOCS] Merges list of discovery and cluster formation settings (elastic#36909) Only compress responses if request was compressed (elastic#36867) Remove duplicate paragraph (elastic#36942) Fix URI to cluster stats endpoint on specific nodes (elastic#36784) Fix typo in unitTest task (elastic#36930) RecoveryMonitor#lastSeenAccessTime should be volatile (elastic#36781) [CCR] Add `ccr.auto_follow_coordinator.wait_for_timeout` setting (elastic#36714) Scripting: Remove deprecated params.ctx (elastic#36848) Refactor the REST actions to clarify what endpoints are deprecated. (elastic#36869) Add JDK 12 to CI rotation (elastic#36915) Improve error message for 6.x style realm settings (elastic#36876) Send clear session as routable remote request (elastic#36805) [DOCS] Remove redundant ILM attributes (elastic#36808) SQL: Fix bug regarding histograms usage in scripting (elastic#36866) Update index mappings when ccr restore complete (elastic#36879) Docs: Bump version to alpha2 after release ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Data Management/Stats
Statistics tracking and retrieval APIs
>docs
General docs changes
v6.4.4
v6.5.5
v6.7.0
v7.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both URIs are actually acceptable, but the one in the docs today is not the
preferred one.