Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Painless] Add String Casting Tests #36945

Merged
merged 3 commits into from
Dec 21, 2018
Merged

[Painless] Add String Casting Tests #36945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c54202
Fix String to char error messages. Add String casting tests.
jdconrad Dec 21, 2018
38c4f2a
Fix tests.
jdconrad Dec 21, 2018
e100929
Merge branch 'master' into number6
jdconrad Dec 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion modules/lang-painless/src/main/java/org/elasticsearch/painless/Utility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,14 @@ public static String charToString(final char value) {
}

public static char StringTochar(final String value) {
if (value == null) {
throw new ClassCastException("cannot cast " +
"null " + String.class.getCanonicalName() + " to " + char.class.getCanonicalName());
}

if (value.length() != 1) {
throw new ClassCastException("Cannot cast [String] with length greater than one to [char].");
throw new ClassCastException("cannot cast " +
String.class.getCanonicalName() + " with length not equal to one to " + char.class.getCanonicalName());
}

return value.charAt(0);
Expand Down
96 changes: 96 additions & 0 deletions modules/lang-painless/src/test/java/org/elasticsearch/painless/StandardCastTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,4 +545,100 @@ public void testNumberCasts() {
expectScriptThrows(ClassCastException.class, () -> exec("Number o = new ArrayList(); ArrayList b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("Number o = new ArrayList(); ArrayList b = (ArrayList)o;"));
}

public void testStringCasts() {
exec("String o = 'string'; Object n = o;");
exec("String o = null; Object n = o;");
exec("String o = 'string'; Object n = (Object)o;");
exec("String o = null; Object n = (Object)o;");

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Number n = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Number n = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Number n = (String)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Number n = (String)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; boolean b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; boolean b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; boolean b = (boolean)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; boolean b = (boolean)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; byte b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; byte b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; byte b = (byte)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; byte b = (byte)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; short b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; short b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; short b = (short)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; short b = (short)o;"));

assertEquals('s', exec("String s = 's'; (char)s"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; char b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; char b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; char b = (char)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; char b = (char)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; int b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; int b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; int b = (int)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; int b = (int)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; long b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; long b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; long b = (long)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; long b = (long)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; float b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; float b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; float b = (float)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; float b = (float)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; double b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; double b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; double b = (double)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; double b = (double)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Boolean b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Boolean b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Boolean b = (Boolean)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Boolean b = (Boolean)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Byte b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Byte b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Byte b = (Byte)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Byte b = (Byte)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Short b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Short b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Short b = (Short)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Short b = (Short)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Character b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Character b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Character b = (Character)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Character b = (Character)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Integer b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Integer b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Integer b = (Integer)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Integer b = (Integer)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Long b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Long b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Long b = (Long)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Long b = (Long)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Float b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Float b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Float b = (Float)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Float b = (Float)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Double b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Double b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; Double b = (Double)o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = null; Double b = (Double)o;"));

expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; ArrayList b = o;"));
expectScriptThrows(ClassCastException.class, () -> exec("String o = 'string'; ArrayList b = (ArrayList)o;"));
}
}
8 changes: 4 additions & 4 deletions modules/lang-painless/src/test/java/org/elasticsearch/painless/StringTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,22 +170,22 @@ public void testStringAndCharacter() {
ClassCastException expected = expectScriptThrows(ClassCastException.class, false, () -> {
assertEquals("cc", exec("return (String)(char)\"cc\""));
});
assertTrue(expected.getMessage().contains("Cannot cast [String] with length greater than one to [char]."));
assertTrue(expected.getMessage().contains("cannot cast java.lang.String with length not equal to one to char"));

expected = expectScriptThrows(ClassCastException.class, false, () -> {
assertEquals("cc", exec("return (String)(char)'cc'"));
});
assertTrue(expected.getMessage().contains("Cannot cast [String] with length greater than one to [char]."));
assertTrue(expected.getMessage().contains("cannot cast java.lang.String with length not equal to one to char"));

expected = expectScriptThrows(ClassCastException.class, () -> {
assertEquals('c', exec("String s = \"cc\"; (char)s"));
});
assertTrue(expected.getMessage().contains("Cannot cast [String] with length greater than one to [char]."));
assertTrue(expected.getMessage().contains("cannot cast java.lang.String with length not equal to one to char"));

expected = expectScriptThrows(ClassCastException.class, () -> {
assertEquals('c', exec("String s = 'cc'; (char)s"));
});
assertTrue(expected.getMessage().contains("Cannot cast [String] with length greater than one to [char]."));
assertTrue(expected.getMessage().contains("cannot cast java.lang.String with length not equal to one to char"));
}

public void testDefConcat() {
Expand Down