-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package ingest-user-agent as a module #36956
Package ingest-user-agent as a module #36956
Conversation
This commit moves ingest-user-agent from being a plugin to being a module that is packaged with Elasticsearch distributions.
Pinging @elastic/es-core-features |
Pinging @elastic/es-core-infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine run gradle build tests 1 |
* master: Fix link to using ingest-geoip Add placeholder ingest-geoip plugin page (elastic#36958)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
if ("ingest-geoip".equals(pluginName)) { | ||
/* | ||
* This is special case handling for ingest-geoip and ingest-user-agent since they are modules now but could have been installed | ||
* from a previous when it was a plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix it in post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit moves ingest-user-agent from being a plugin to being a module that is packaged with Elasticsearch distributions.
Thanks @martijnvg and @rjernst. |
ingest-geoip and ingest-user-agent are now packaged as modules in Elasticsearch. Relates to elastic/elasticsearch#36956 and elastic/elasticsearch#36246
ingest-geoip and ingest-user-agent are now packaged as modules in Elasticsearch. Relates to elastic/elasticsearch#36956 and elastic/elasticsearch#36246
This commit moves ingest-user-agent from being a plugin to being a module that is packaged with Elasticsearch distributions.