Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation check for index_options on numeric fields #37026

Closed
wants to merge 1 commit into from
Closed

Deprecation check for index_options on numeric fields #37026

wants to merge 1 commit into from

Conversation

gwbrown
Copy link
Contributor

@gwbrown gwbrown commented Dec 28, 2018 •
edited
Loading

Checks for index_options on numeric fields, which are not supported in
7.0. The indices will still be available, but attempting to make
modifications to the mapping appear to result in errors, which is why
this is a WARNING rather than CRITICAL.
See note below.

Relates to #36024 and #26668

@gwbrown
Dep. check for index_options on numeric fields
c87941a 
Checks for index_options on numeric fields, which are not supported in
7.0. The indices will still be available, but attempting to make
modifications to the mapping appear to result in errors, which is why
this is a `WARNING` rather than `CRITICAL`.
@gwbrown gwbrown added >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types :Core/Features/Features v6.7.0 labels Dec 28, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@gwbrown gwbrown mentioned this pull request Dec 28, 2018
Closed
26 tasks
@gwbrown gwbrown changed the title Dep. check for index_options on numeric fields Deprecation check for index_options on numeric fields Dec 28, 2018
@gwbrown
Copy link
Contributor Author

gwbrown commented Dec 28, 2018

Disregard this, I misunderstood what changed here and made a mistake in my testing - index_options on numeric fields are special cased and behave fine in 7.0 if they were created in 6.x, so we don't need a check for this.

@gwbrown gwbrown closed this Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher Awaiting requested review from cbuescher

Assignees
No one assigned
Labels
>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types v6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gwbrown @elasticmachine @danielmitterdorfer