Compatability mode for forbidden APIs for Java 12 #37199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpar-t
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
rjernst
reviewed
Jan 7, 2019
| project.runtimeJavaVersion.getMajorVersion() : project.runtimeJavaVersion | ||
| if (project.runtimeJavaVersion > JavaVersion.VERSION_11) { | ||
| doLast { | ||
| println "Forbidden APIs does not support java version past 11. Will use the signatures from 11 for " + |
There was a problem hiding this comment.
Why a bare print statement? Seems this should at least be a warning log. But what can a dev do about it? Maybe nothing should be printed and an issue created and linked here to remove once forbidden apis supports Java 12.
There was a problem hiding this comment.
I agree, i converted it to info so it leaves a trace in CI.
An issue isn't actionable either unless we implement the support in forbidden APIs ourselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the maximum
targetVersionwe setforbiddenApisto. No support for Java 12 yet.Closes #37007.