Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the need for JAVA11_HOME #37589

Merged
merged 2 commits into from
Jan 18, 2019
Merged

Conversation

hmcc
Copy link
Contributor

@hmcc hmcc commented Jan 17, 2019

Connected to #37586.

The contributor guidelines mention JAVA8_HOME, JAVA9_HOME and JAVA10_HOME, but not JAVA11_HOME.

When I run ./gradlew buildBwcVersion, it fails unless JAVA11_HOME is set, so I've added this to the list.

I can't find any mention of JAVA9_HOME or JAVA10_HOME other than in this file - are these still needed?

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@rjernst rjernst merged commit fc1c476 into elastic:master Jan 18, 2019
@rjernst
Copy link
Member

rjernst commented Jan 18, 2019

Thanks @hmcc!

rjernst pushed a commit that referenced this pull request Jan 18, 2019
This commit updates the contribution docs to include java11 as a requirement for building and testing Elasticsearch.
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 21, 2019
* elastic/master: (104 commits)
  Permission for restricted indices (elastic#37577)
  Remove Watcher Account "unsecure" settings (elastic#36736)
  Add cache cleaning task for ML snapshot (elastic#37505)
  Update jdk used by the docker builds (elastic#37621)
  Remove an unused constant in PutMappingRequest.
  Update get users to allow unknown fields (elastic#37593)
  Do not add index event listener if CCR disabled (elastic#37432)
  Add local session timeouts to leader node (elastic#37438)
  Add some deprecation optimizations (elastic#37597)
  refactor inner geogrid classes to own class files (elastic#37596)
  Remove obsolete deprecation checks (elastic#37510)
  ML: Add support for single bucket aggs in Datafeeds (elastic#37544)
  ML: creating ML State write alias and pointing writes there (elastic#37483)
  Deprecate types in the put mapping API. (elastic#37280)
  [ILM] Add unfollow action (elastic#36970)
  Packaging: Update marker used to allow ELASTIC_PASSWORD (elastic#37243)
  Fix setting openldap realm ssl config
  Document the need for JAVA11_HOME (elastic#37589)
  SQL: fix object extraction from sources (elastic#37502)
  Nit in settings.gradle for Eclipse
  ...
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >docs General docs changes Team:Delivery Meta label for Delivery team v6.7.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants