Enable SSL in reindex with security QA tests #37600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the x-pack/qa/reindex-tests-with-security integration tests to run with TLS enabled on the Rest interface.
tvernum
added
>test
|
Pinging @elastic/es-security |
|
This test will fail until #37527 is merged, as reindex doesn't support SSL yet. |
jaymode
approved these changes
Jan 18, 2019
| // Check whether the cluster has started | ||
| URL url = new URL("https://${node.httpUri()}/_cluster/health?wait_for_nodes=${numNodes}&wait_for_status=yellow"); | ||
| for (int i = 0; i < 20; i++) { | ||
| // we use custom wait logic here for HTTPS |
There was a problem hiding this comment.
I think it would be awesome to unify this wait logic with that in smoke-test-plugins-ssl, potentially as a followup. Maybe @atorok has some guidance on the best way to do that?
There was a problem hiding this comment.
Yes, I think we probably want to replace the existing Ant task we use for this with our own task that can read from a custom truststore (or perhaps PEM so it can run on a FIPS JVM).
alpar-t
reviewed
Jan 22, 2019
| logger.info("HTTP response was [{}]", httpURLConnection.getResponseCode()); | ||
| } | ||
| } catch (IOException e) { | ||
| logger.info("Failed to call cluster health - " + e) |
There was a problem hiding this comment.
I think this will be too verbose in CI , would only log the last one.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 31, 2019
* master: (100 commits) Push primary term to replication tracker (elastic#38044) Introduce ability to minimize round-trips in CCS (elastic#37828) Don't Assert Ack on when Publish Timeout is 0 in Test (elastic#38077) Reduce object creation in Rounding class (elastic#38061) Treat put-mapping calls with `_doc` as a top-level key as typed calls. (elastic#38032) Fix test bug when testing the merging of mappings and templates. (elastic#38021) spelling: java script -- not JavaScript (elastic#37057) Enable SSL in reindex with security QA tests (elastic#37600) Disable BWC tests during backport (elastic#38074) SQL: Added SSL configuration options tests (elastic#37875) Minor fixes in the release notes script. (elastic#37967) Fix typo in docs. (elastic#38018) Update Lucene repo for 7.0.0-alpha2 (elastic#37985) Fix size of rolling-upgrade bootstrap config (elastic#38031) fix DateIndexNameProcessorTests offset pattern (elastic#38069) Speed up converting of temporal accessor to zoned date time (elastic#37915) Work around JDK8 timezone bug in tests (elastic#37968) Correct arg names when update mapping/settings from leader (elastic#38063) Introduce ssl settings to reindex from remote (elastic#37527) Mute testRetentionLeasesSyncOnExpiration ...
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Feb 4, 2019
Update the x-pack/qa/reindex-tests-with-security integration tests to run with TLS enabled on the Rest interface. Backport of: elastic#37600 Relates: elastic#37527
tvernum
added a commit
that referenced
this pull request
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the x-pack/qa/reindex-tests-with-security integration tests to
run with TLS enabled on the Rest interface.
Relates: #37527