Issue deprecation warning if TLSv1.0 is used without explicit config #37788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TLSv1.0 will be removed from the default list of supported protocols in v7.0. This change adds deprecation warnings when a TLS v1.0 connection is used without having been explictly configured as a supported protocol. Such situations will fail in Elasticsearch 7.x
|
Is there a plan to do anything for LDAP connections? |
No plan, but I'll have a look. |
|
This PR now covers both LDAP and SAML metadata (https) connections. |
jkakavas
approved these changes
Jan 28, 2019
|
@elasticmachine test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #37512 we're removing TLS 1.0 from the default protocols list in 7.0
This change adds deprecation warnings if any SSL context is relying on the default protocols list and a TLSv1 connection is established (incoming or outgoing).
This covers:
HttpClient)HttpExporter)SessionFactory)SamlRealm)Deprecations for incoming HTTP connections are included in the
Warningheaders sent back to that client. For the other contexts, the deprecation log must be used.