AsyncTwoPhaseIndexerTests race condition fixed #37830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgomulka
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
pgomulka
commented
Jan 24, 2019
| indexer.start(); | ||
| assertThat(indexer.getState(), equalTo(IndexerState.STARTED)); | ||
| assertTrue(indexer.maybeTriggerAsyncJob(System.currentTimeMillis())); | ||
| Thread.sleep(1000); |
costin
approved these changes
Jan 25, 2019
| assertThat(step, equalTo(3)); | ||
| ++step; | ||
| return new IterationResult<Integer>(Collections.emptyList(), 3, true); | ||
| } | ||
|
|
||
| private void awaitForLatch() { | ||
| try { | ||
| latch.await(); |
There was a problem hiding this comment.
Please put a timeout (10s or whatever you think it's appropriate) to prevent this for hanging up.
|
@elasticmachine run elasticsearch-ci/1 |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 25, 2019
* elastic/master: (68 commits) Fix potential IllegalCapacityException in LLRC when selecting nodes (elastic#37821) Mute CcrRepositoryIT#testFollowerMappingIsUpdated Fix S3 Repository ITs When Docker is not Available (elastic#37878) Pass distribution type through to docs tests (elastic#37885) Mute SharedClusterSnapshotRestoreIT#testSnapshotCanceledOnRemovedShard SQL: Fix casting from date to numeric type to use millis (elastic#37869) Migrate o.e.i.r.RecoveryState to Writeable (elastic#37380) ML: removing unnecessary upgrade code (elastic#37879) Relax cluster metadata version check (elastic#37834) Mute TransformIntegrationTests#testSearchTransform Refactored GeoHashGrid unit tests (elastic#37832) Fixes for a few randomized agg tests that fail hasValue() checks Geo: replace intermediate geo objects with libs/geo (elastic#37721) Remove NOREPLACE for /etc/elasticsearch in rpm and deb (elastic#37839) Remove "reinstall" packaging tests (elastic#37851) Add unit tests for ShardStateAction's ShardStartedClusterStateTaskExecutor (elastic#37756) Exit batch files explictly using ERRORLEVEL (elastic#29583) TransportUnfollowAction should increase settings version (elastic#37859) AsyncTwoPhaseIndexerTests race condition fixed (elastic#37830) Do not allow negative variances (elastic#37384) ...
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Feb 1, 2019
The unlucky timing can cause this test to fail when the indexing is triggered from `maybeTriggerAsyncJob`. As this is asynchronous, in can finish quicker then the test stepping over to next assertion The introduced barrier solves the problem closes elastic#37695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unlucky timing can cause this test to fail when the indexing triggered from
maybeTriggerAsyncJob. As this is asynchronous, in can finish quicker then the test stepping over to next assertionThe introduced barrier solves the problem
closes #37695