Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate types in create index requests (backport to 6.x). #37838

Merged
merged 8 commits into from
Jan 27, 2019
Merged

Deprecate types in create index requests (backport to 6.x). #37838

merged 8 commits into from
Jan 27, 2019

Commits on Jan 24, 2019

  1. Deprecate types in create index requests. (#37134) 

    From #29453 and #37285, the include_type_name parameter was already present and defaulted to false. This PR makes the following updates:
* Add deprecation warnings to RestCreateIndexAction, plus tests in RestCreateIndexActionTests.
* Add a typeless 'create index' method to the Java HLRC, and deprecate the old typed version. To do this cleanly, I created new CreateIndexRequest and CreateIndexResponse objects that differ from the existing server ones.
    @jtibshirani
    jtibshirani committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    1bebc05 View commit details
    Browse the repository at this point in the history

  2. Remove outdated callouts from the 'create index' HLRC docs

    @jtibshirani
    jtibshirani committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    437d08d View commit details
    Browse the repository at this point in the history

  3. Updates to account for different default for include_type_name

    @jtibshirani
    jtibshirani committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    7438dfe View commit details
    Browse the repository at this point in the history

  4. Fix static analysis violations.

    @jtibshirani
    jtibshirani committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    ae71a64 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2019

  1. Merge remote-tracking branch 'upstream/6.x' into deprecate-types-in-c… 

    …reate-index
    @jtibshirani
    jtibshirani committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    edc63f9 View commit details
    Browse the repository at this point in the history

  2. Fix IndicesRequestConvertersTests.

    @jtibshirani
    jtibshirani committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    d00c6ff View commit details
    Browse the repository at this point in the history

  3. Make sure the deprecated 'get field mappings' call specifies include_… 

    …type_name.
    @jtibshirani
    jtibshirani committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    28542ad View commit details
    Browse the repository at this point in the history

  4. Fix some HLRC tests.

    @jtibshirani
    jtibshirani committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    eae5856 View commit details
    Browse the repository at this point in the history