Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in Logfile Audit Filter (#38120) #38271

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Fix NPE in Logfile Audit Filter (#38120) #38271

merged 1 commit into from
Feb 3, 2019

Commits on Feb 3, 2019

  1. Fix NPE in Logfile Audit Filter (elastic#38120) 

    The culprit in elastic#38097 is an `IndicesRequest` that has no indices,
but instead of `request.indices()` returning `null` or `String[0]`
it returned `String[] {null}` . This tripped the audit filter.

I have addressed this in two ways:
1. `request.indices()` returning `String[] {null}` is treated as `null`
    or `String[0]`, i.e. no indices
2. `null` values among the roles and indices lists, which are
    unexpected, will never again stumble the audit filter; `null` values
    are treated as special values that will not match any policy,
    i.e. their events will always be printed.

Closes elastic#38097
    @albertzaharovits
    albertzaharovits committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    7745816 View commit details
    Browse the repository at this point in the history