Remove several uses of 6.x version constants #41162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes many conditionals in serialization, as well as tests which no longer need to be compatible with 6.x now that master is 8.0. Additionally, many tests are changed to not depend on a fixed version, but instead use new helper methods for getting the range of index compatible versions with the current version, which will make the tests not need changes in the future when version constants are removed.
rjernst
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
|
relates #41164 |
talevy
reviewed
Apr 15, 2019
test/framework/src/main/java/org/elasticsearch/test/AbstractBuilderTestCase.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/VersionUtils.java
Outdated
Show resolved
Hide resolved
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This commit removes many conditionals in serialization, as well as tests which no longer need to be compatible with 6.x now that master is 8.0. Additionally, many tests are changed to not depend on a fixed version, but instead use new helper methods for getting the range of index compatible versions with the current version, which will make the tests not need changes in the future when version constants are removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes many conditionals in serialization, as well as tests
which no longer need to be compatible with 6.x now that master is 8.0.
Additionally, many tests are changed to not depend on a fixed version,
but instead use new helper methods for getting the range of index
compatible versions with the current version, which will make the tests
not need changes in the future when version constants are removed.