Remove Version.V_6_0_0 constant from PercolatorMatchedSlotSubFetchPhase #41995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>non-issue
:Search Relevance/Percolator
|
Pinging @elastic/es-search |
jimczi
reviewed
May 9, 2019
| // for now we just use version 6.0 version to find nested parent | ||
| final Version version = Version.V_6_0_0; //context.mapperService().getIndexSettings().getIndexVersionCreated(); | ||
| Weight weight = percolatorIndexSearcher.createWeight(percolatorIndexSearcher.rewrite(Queries.newNonNestedFilter(version)), | ||
| Query nonNestedQuery = Queries.newNonNestedFilter(indexVersionCreated); |
There was a problem hiding this comment.
We can remove the version here too since it only checks if the index was created before 6.1.0. We can do this in a follow up but we probably don't need to add the indexVersionCreated param here and just use CURRENT until we remove it from newNonNestedFilter ?
There was a problem hiding this comment.
👍 That makes sense. I will update this PR.
jimczi
approved these changes
May 9, 2019
There's already a pr opened to remove all use of v6 constants: |
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…se (elastic#41995) and use Version.CURRENT instead of passing down index created version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.