Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure SHA256 is not used in tests #42289

Merged
merged 6 commits into from
May 22, 2019
Merged

Ensure SHA256 is not used in tests #42289

merged 6 commits into from
May 22, 2019

Commits on May 21, 2019

  1. Ensure SHA256 is not used in tests 

    SHA256 was recently added to the Hasher class in order to be used
in the TokenService. A few tests were still using values() to get
the available algorithms from the Enum and it could happen that
SHA256 would be picked up by these.
This change adds an extra convenience method
(Hasher#getAvailableAlgoCacheHash) and enures that only this and
Hasher#getAvailableAlgoStoredHash are used for getting the list of
available password hashing algorithms in our tests.
    @jkakavas
    jkakavas committed May 21, 2019
    Configuration menu
    Copy the full SHA
    1380827 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into fix-cachingrealm-test

    @jkakavas
    jkakavas committed May 21, 2019
    Configuration menu
    Copy the full SHA
    46b092d View commit details
    Browse the repository at this point in the history

  3. Remove unused imports

    @jkakavas
    jkakavas committed May 21, 2019
    Configuration menu
    Copy the full SHA
    edf72ad View commit details
    Browse the repository at this point in the history

  4. Add Hasher#values() to the forbidden APIs

    @jkakavas
    jkakavas committed May 21, 2019
    Configuration menu
    Copy the full SHA
    f6a8487 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into fix-cachingrealm-test

    @jkakavas
    jkakavas committed May 21, 2019
    Configuration menu
    Copy the full SHA
    d7886d8 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into fix-cachingrealm-test

    @jkakavas
    jkakavas committed May 21, 2019
    Configuration menu
    Copy the full SHA
    4b21a4f View commit details
    Browse the repository at this point in the history